Fixes cleanup of append-only test tempfiles on macOS/BSD#9560
Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom Apr 4, 2026
Merged
Fixes cleanup of append-only test tempfiles on macOS/BSD#9560ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
Conversation
The `test_extract_restores_append_flag` test leaves append-only tempfiles around on macOS and FreeBSD that cannot be removed cleanly, this was previously just ignored by the cleanup func but those files occasionally caused lots of warning output on subsequent test runs. Fixed by attempting to clear flags and retry whenever the cleanup function fails.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9560 +/- ##
=======================================
Coverage 83.36% 83.36%
=======================================
Files 87 87
Lines 15481 15489 +8
Branches 2325 2326 +1
=======================================
+ Hits 12905 12912 +7
- Misses 1822 1824 +2
+ Partials 754 753 -1 ☔ View full report in Codecov by Sentry. |
Member
|
Ah, good catch! I already wondered why it does not clean up everything, but didn't debug it yet. |
Member
|
BTW, the haiku test failure comes from setuptools_scm + its dependencies, just ignore it for now. |
Contributor
Author
|
Codecov triggers on conftest.py? 🤔 Maybe that should be ignored or moved into the testsuite. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
test_extract_restores_append_flagtest leaves append-only tempfiles around on macOS and FreeBSD that cannot be removed cleanly. This was previously just ignored by the cleanup func but those files occasionally caused lots of warning output on subsequent test runs. Fixed by attempting to clear flags and retry whenever the cleanup function fails.I am not entirely sure what triggers the warnings, I can usually do a couple of test runs before the warnings start showing even though the files would have been left around after the first test run. Cleaning them up properly is the right thing to do anyway.
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)